fix: variables passed to included taskfile #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Mar 10, 2024
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
It doesn't look like a breaking change to me. It looks more like a bug fix. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1256
Fixes #1503
Quite a small/simple change that allows #1503 to work as expected. I would personally have expected the changes in #1256 to have required the use of
defaultto work correctly. This feels more consistent with how was pass variables around between tasks, but I might be misunderstanding. Variable propagation is complicated in Task 😆Is this a breaking change?