Skip to content

Conversation

@nett32
Copy link

@nett32 nett32 commented Aug 1, 2019

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Copy link
Member

methane commented Aug 1, 2019

I don't like it. It doesn't true decimal support.
It is just pass the string without escaping or quoting.
Essencially, it is same to fmt.Sprintf, but far complicated and poor performance.

@nett32
Copy link
Author

nett32 commented Aug 15, 2019

@methane I updated the code implementation.

@methane
Copy link
Member

methane commented Nov 8, 2019

It doesn't make sense at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants