Skip to content

performance improvement for time format #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 5 commits into from
Aug 13, 2020
Merged

performance improvement for time format #1118

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e4890f
feat: feat: performance improvement for time format
chanxuehong May 30, 2020
f9f72b5
feat: rm some test functions
chanxuehong Jun 1, 2020
3a20c98
feat: change formatDateTime accept an input buf
chanxuehong Jun 1, 2020
8f7a847
Merge pull request #1 from go-sql-driver/master
chanxuehong Jun 1, 2020
9b49409
feat: restore the original blank line
chanxuehong Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: restore the original blank line
  • Loading branch information
@chanxuehong
chanxuehong committed Jun 1, 2020
commit 9b49409905757f35d8b8045b5879a95bf3ee7e13
3 changes: 3 additions & 0 deletions packets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,7 @@ func (stmt *mysqlStmt) writeExecutePacket(args []driver.Value) error {

var a [64]byte
var b = a[:0]

if v.IsZero() {
b = append(b, "0000-00-00"...)
} else {
Expand All @@ -1120,10 +1121,12 @@ func (stmt *mysqlStmt) writeExecutePacket(args []driver.Value) error {
return err
}
}

paramValues = appendLengthEncodedInteger(paramValues,
uint64(len(b)),
)
paramValues = append(paramValues, b...)

default:
return fmt.Errorf("cannot convert type: %T", arg)
}
Expand Down