Skip to content

Pass tests on Apple silicon #951

Closed
Closed
@jchamberlain

Description

@jchamberlain

Tegola's tests don't pass on M1/M2 Macs for two reasons:

  1. Many calculated floats are slightly (insignificantly) different, but SQL string comparisons in the PostGIS and Hana providers expect an exact match.
  2. TestGenerateTilesForBounds fails because of a bug in go-spatial/geom (uint overflow, resulting in implementation-specific behavior—see cmd/compile: casting a negative float to uint64 has different behavior on arm64 and amd64 golang/go#52943). The geom code in question has since been rewritten and does not exhibit the same bug, so upgrading fixes it.

From my perspective, (2) is best fixed by upgrading go-spatial/geom. But that introduces its own trouble in that some float calculations are even more different (exacerbating 1), and backward-incompatible changes have been made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions