Google Cloud Storage cache adapter

[matheusmatos]

Hi guys,

Is anyone working on a GCP caching adapter?

Would a pull request implementing this be welcome?

[ARolek]

@matheusmatos I'm not aware of anyone tacking this issue and a PR would be welcome!

[matheusmatos]

Great! I started working on it in this branch:

https://github.com/matheusmatos/tegola/tree/@matheusmatos/cache-gcp

I will share the progress!

[ARolek]

Nice! I have 0 experience with that service so all I can do I help with code review from an implementation standpoint, but not a correct / best practices standpoint specific to the service.

[matheusmatos]

Excellent! In fact, I've experience with GCP but not so much with GoLang. I opened the PR (#891) but I think it's not ready to be merged yet.

I needed to add the cloud.google.com/go/storage package and it created a lot of files inside vendor folder. Is it correct for this to be committed to Git?

[ARolek]

Yeah vendoring will copy all the files to the vendor directory. This is our preferred approach. Ideally the vendoring happens in a separate commit from the implementation.

[matheusmatos]

Okay, I'll resend it as two commits; implementation and vendor.

[matheusmatos]

I sent the two commits. I'm not sure if the vendor commit is correct. Any help is appreciated. Thanks!

[dthib]

Hi @ARolek, thanks for the great work. I am interested in this PR too (thanks @matheusmatos too!). Any news when it can be merged ?
Best

[iwpnd]

@dthib @matheusmatos

the gcs cache adapter is in the latest master, see here. If you're running tegola from a container you can

docker pull gospatial/tegola:edge

[dthib]

Ok great thanks for the reply @ARolek

[ARolek]

Yep, looks like this was merged into master already: #891. I'm going to close this issue out. As @iwpnd mentioned, you can pull the most recent docker image using the command he posted. You can also pick up build artifacts from the CI: https://github.com/go-spatial/tegola/actions/runs/3650751309