Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to customize the XML marshal/unmarshal functions #481 #484

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Adding ability to customize the XML marshal/unmarshal functions #481 #484

merged 1 commit into from
Nov 4, 2021

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Oct 31, 2021 •
edited
Loading

For #481

@jeevatkm jeevatkm added this to the v2.7.0 Milestone milestone Oct 31, 2021
@jeevatkm jeevatkm self-assigned this Oct 31, 2021
@codecov
Copy link

codecov bot commented Oct 31, 2021 •
edited
Loading

Codecov Report

Merging #484 (5965565) into master (d837dfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   96.68%   96.69%           
=======================================
  Files          10       10           
  Lines        1328     1330    +2     
=======================================
+ Hits         1284     1286    +2     
  Misses         26       26           
  Partials       18       18
Impacted Files Coverage Δ
client.go 97.64% <100.00%> (+0.01%) ⬆️
middleware.go 92.85% <100.00%> (ø)
util.go 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d837dfc...5965565. Read the comment docs.

@jeevatkm jeevatkm mentioned this pull request Oct 31, 2021
Merged
moorereason
moorereason requested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. 👍

Can you update the README with an example usage? The use case from #481 would work well.

Also, I noticed that we don't provide examples of using the JSONMarshal/JSONUnmarshal feature, but we can add that in a separate PR.

@jeevatkm
Copy link
Member Author

jeevatkm commented Nov 2, 2021 •
edited
Loading

@moorereason Sure, I will update the readme on PR #485 since the late addition to doc, thanks. We can proceed with this PR.

moorereason
moorereason approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeevatkm jeevatkm merged commit 7dda615 into master Nov 4, 2021
@jeevatkm jeevatkm deleted the for-gh481 branch November 4, 2021 05:21
hurracrane pushed a commit to Shopify/resty that referenced this pull request May 17, 2022
@jeevatkm @hurracrane
Adding ability to customize the XML marshal/unmarshal functions go-re…
259814c 
…sty#481 (go-resty#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moorereason moorereason moorereason approved these changes

Assignees

@jeevatkm jeevatkm

Labels
enhancement
Milestone
v2.7.0 Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeevatkm @moorereason