Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#432): Implement Easier Adding of Multiple Value HTTP Header #452

Merged
merged 5 commits into from
Sep 12, 2021
Merged

feat(#432): Implement Easier Adding of Multiple Value HTTP Header #452

merged 5 commits into from
Sep 12, 2021

Conversation

mhdiiilham
Copy link
Contributor

@mhdiiilham mhdiiilham commented Sep 1, 2021 •
edited by jeevatkm
Loading

Implement easier adding of multiple value HTTP Header with function SetMultiValueHeaders

Closes #432

@mhdiiilham
feat(go-resty#432): Implement Easier Adding of Multiple Value HTTP He…
ae037fd 
…ader

Implement easier adding of multiple value HTTP Header with function `SetMultiValueHeaders`
moorereason
moorereason reviewed Sep 1, 2021
View reviewed changes
request.go Outdated Show resolved Hide resolved
moorereason
moorereason reviewed Sep 6, 2021
View reviewed changes
request.go Outdated Show resolved Hide resolved
jeevatkm
jeevatkm requested changes Sep 12, 2021
View reviewed changes
request.go Outdated Show resolved Hide resolved
@jeevatkm
Copy link
Member

@mhdiiilham Thank you for your PR appreciated, I'm sorry for the delayed response. Please check the review comment.

@mhdiiilham
Copy link
Contributor Author

@mhdiiilham Thank you for your PR appreciated, I'm sorry for the delayed response. Please check the review comment.

Hi, yes I updated the method name

@codecov
Copy link

codecov bot commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #452 (30e96ae) into master (70336cb) will increase coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   96.06%   96.85%   +0.79%     
==========================================
  Files          10       10              
  Lines        1041     1304     +263     
==========================================
+ Hits         1000     1263     +263     
  Misses         23       23              
  Partials       18       18
Impacted Files Coverage Δ
request.go 100.00% <100.00%> (ø)
resty.go 100.00% <0.00%> (ø)
retry.go 100.00% <0.00%> (ø)
trace.go 100.00% <0.00%> (ø)
response.go 100.00% <0.00%> (ø)
transport.go 100.00% <0.00%> (ø)
client.go 97.59% <0.00%> (+0.73%) ⬆️
middleware.go 92.52% <0.00%> (+1.02%) ⬆️
util.go 93.93% <0.00%> (+2.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70336cb...30e96ae. Read the comment docs.

rizalgowandy
rizalgowandy approved these changes Sep 12, 2021
View reviewed changes
Copy link

@rizalgowandy rizalgowandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeevatkm jeevatkm added enhancement v2 For resty v2 labels Sep 12, 2021
@jeevatkm jeevatkm added this to the v2.7.0 Milestone milestone Sep 12, 2021
jeevatkm
jeevatkm reviewed Sep 12, 2021
View reviewed changes
request.go
// "Accept": []string{"text/html", "application/xhtml+xml", "application/xml;q=0.9", "image/webp", "*/*;q=0.8"},
// })
// Also you can override header value, which was set at client instance level.
func (r *Request) SetHeaderMultiValues(headers map[string][]string) *Request {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdiiilham @rizalgowandy FYI, godoc is not updated with the updated method name. I will be doing that. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, I'm sorry I missed the godoc comment. Thank you @jeevatkm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdiiilham No worries, I just did. Maybe next time 👍

jeevatkm
jeevatkm approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdiiilham Thanks for your PR and contribution.

@jeevatkm jeevatkm merged commit ecf7cda into go-resty:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rizalgowandy rizalgowandy rizalgowandy approved these changes

@jeevatkm jeevatkm jeevatkm approved these changes

@moorereason moorereason Awaiting requested review from moorereason

Assignees

@mhdiiilham mhdiiilham

Labels
enhancement hacktoberfest-accepted v2 For resty v2
Milestone
v2.7.0 Milestone
Development

Successfully merging this pull request may close these issues.

Implement easier adding of multi-value http headers
4 participants
@mhdiiilham @jeevatkm @moorereason @rizalgowandy