You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, SetHostURL() is a bit ambiguous in its wording. A more appropriate term would perhaps instead be "SetBaseURL" or the like. "HostURL" sounds more like specifying a Host header to me. Alternatively, this can be made a bit more clear by specifying a path other than / in the example in the documentation, such as client.SetHostURL("http://httpbin.org/some/path") ("Unique settings at Client level").
Take it or leave it, but would have saved me five minutes. 👍
The text was updated successfully, but these errors were encountered:
@johnnybubonic Thanks for reaching out and sharing your thoughts.
Yeah, the name SetBaseURL suitable name too. This is a breaking change, so parking it for v3.0.0
@johnnybubonic Had another thought. Possibly we can add a new method SetBaseURL and deprecated the SetHostURL. So that on v3.0.0, it will become feasible to remove deprecated elements.
Currently, SetHostURL() is a bit ambiguous in its wording. A more appropriate term would perhaps instead be "SetBaseURL" or the like. "HostURL" sounds more like specifying a
Host
header to me. Alternatively, this can be made a bit more clear by specifying a path other than/
in the example in the documentation, such asclient.SetHostURL("http://httpbin.org/some/path")
("Unique settings at Client level").Take it or leave it, but would have saved me five minutes. 👍
The text was updated successfully, but these errors were encountered: