Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement adapter Name and add Name constant #53

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Implement adapter Name and add Name constant #53

merged 5 commits into from
Oct 9, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Oct 3, 2023 •
edited
Loading

Depends on go-rel/rel#346 and go-rel/sql#59

Add also MustOpen method similar to other adapters

@lafriks lafriks added the enhancement New feature or request label Oct 3, 2023
@lafriks lafriks mentioned this pull request Oct 3, 2023
Open
Fs02
Fs02 reviewed Oct 3, 2023
View reviewed changes
sqlite3.go Show resolved Hide resolved
@lafriks lafriks changed the title Implement adapter DBType and add Name constant Implement adapter Name and add Name constant Oct 7, 2023
@lafriks lafriks marked this pull request as ready for review October 8, 2023 09:47
@lafriks lafriks requested a review from Fs02 October 8, 2023 11:06
Fs02
Fs02 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fs02 Fs02 merged commit 730f4a6 into go-rel:main Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fs02 Fs02 Fs02 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lafriks @Fs02