Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for adapters to implement custom column option mappers #55

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Sep 26, 2023

Will need to add ColumnOptionsMapper: sql.ColumnOptionsMapper for all adapters, will do that once this is merged.

Needed so that it's possible to implement auto increment for ID, BigID columns for SQLite3 adapter

@lafriks lafriks added the enhancement New feature or request label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (59e0433) 100.00% compared to head (93dbf21) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          615       610    -5     
=========================================
- Hits           615       610    -5     
Files Coverage Δ
builder/table.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lafriks lafriks requested a review from Fs02 September 26, 2023 23:25
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@Fs02 Fs02 merged commit 4af8144 into go-rel:main Sep 26, 2023
6 checks passed
@lafriks lafriks deleted the feat/column_options branch September 26, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants