Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added availability create adapters with already opened db #69

Merged
merged 2 commits into from
May 30, 2020
Merged

Added availability create adapters with already opened db #69

merged 2 commits into from
May 30, 2020

Conversation

snovichkov
Copy link
Contributor

Plz review my PR. Thx.

Fs02
Fs02 requested changes May 30, 2020
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, and code coverage to be fixed.

Thanks for the pull request :)

adapter/mysql/mysql.go Outdated Show resolved Hide resolved
adapter/postgres/postgres.go Outdated Show resolved Hide resolved
@snovichkov
Copy link
Contributor Author

@Fs02 All done.

Fs02
Fs02 approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍

@Fs02 Fs02 merged commit 25d7dfb into go-rel:master May 30, 2020
fairking pushed a commit to fairking/rel that referenced this pull request Apr 16, 2024
Alias issue go-rel#69
e9d4756
@fairking fairking mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fs02 Fs02 Fs02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snovichkov @Fs02