Add Reset function to remove history of a key #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Nov 19, 2020
rate.go
Outdated
| @@ -158,6 +158,15 @@ func (l Limiter) AllowAtMost( | |||
| return res, nil | |||
| } | |||
|
|
|||
| // Reset gets a key and reset all limitations and previous usages | |||
| func (l *Limiter) Reset(ctx context.Context, key string) error { | |||
| _, err := reset.Run(ctx, l.rdb, []string{redisPrefix + key}, nil).Result() | |||
There was a problem hiding this comment.
Please remove Lua script and just call l.rdb.Del(ctx, redisPrefix + key)
There was a problem hiding this comment.
Thanks for the comment. I just removed the script and used the Del function instead.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I just added a new Lua script that removes the corresponding key from Redis to reset its functionality.