Skip to content

fix: add missing translations for alpha validators #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shindonghwi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add missing translations for alpha validators #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions translations/en/en.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,26 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
translation: "{0} can only contain alphanumeric characters",
override: false,
},
{
tag: "alphaspace",
translation: "{0} can only contain alphabetic and space characters",
override: false,
},
{
tag: "alphanumspace",
translation: "{0} can only contain alphanumeric and space characters",
override: false,
},
{
tag: "alphaunicode",
translation: "{0} can only contain unicode alphabetic characters",
override: false,
},
{
tag: "alphanumunicode",
translation: "{0} can only contain unicode alphanumeric characters",
override: false,
},
{
tag: "numeric",
translation: "{0} must be a valid numeric value",
Expand Down
26 changes: 23 additions & 3 deletions translations/en/en_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,13 @@ func TestTranslations(t *testing.T) {
GteFieldString string `validate:"gtefield=MaxString"`
LtFieldString string `validate:"ltfield=MaxString"`
LteFieldString string `validate:"ltefield=MaxString"`
AlphaString string `validate:"alpha"`
AlphanumString string `validate:"alphanum"`
NumericString string `validate:"numeric"`
AlphaString string `validate:"alpha"`
AlphanumString string `validate:"alphanum"`
AlphaSpaceString string `validate:"alphaspace"`
AlphaNumSpaceString string `validate:"alphanumspace"`
AlphaUnicodeString string `validate:"alphaunicode"`
AlphaNumUnicodeString string `validate:"alphanumunicode"`
NumericString string `validate:"numeric"`
NumberString string `validate:"number"`
HexadecimalString string `validate:"hexadecimal"`
HexColorString string `validate:"hexcolor"`
Expand Down Expand Up @@ -487,6 +491,22 @@ func TestTranslations(t *testing.T) {
ns: "Test.AlphaString",
expected: "AlphaString can only contain alphabetic characters",
},
{
ns: "Test.AlphaSpaceString",
expected: "AlphaSpaceString can only contain alphabetic and space characters",
},
{
ns: "Test.AlphaNumSpaceString",
expected: "AlphaNumSpaceString can only contain alphanumeric and space characters",
},
{
ns: "Test.AlphaUnicodeString",
expected: "AlphaUnicodeString can only contain unicode alphabetic characters",
},
{
ns: "Test.AlphaNumUnicodeString",
expected: "AlphaNumUnicodeString can only contain unicode alphanumeric characters",
},
{
ns: "Test.LtFieldString",
expected: "LtFieldString must be less than MaxString",
Expand Down
20 changes: 20 additions & 0 deletions translations/ko/ko.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,26 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
translation: "{0}은(는) 알파벳과 숫자만 포함할 수 있습니다.",
override: false,
},
{
tag: "alphaspace",
translation: "{0}은(는) 알파벳과 공백만 포함할 수 있습니다.",
override: false,
},
{
tag: "alphanumspace",
translation: "{0}은(는) 알파벳, 숫자, 공백만 포함할 수 있습니다.",
override: false,
},
{
tag: "alphaunicode",
translation: "{0}은(는) 유니코드 문자만 포함할 수 있습니다.",
override: false,
},
{
tag: "alphanumunicode",
translation: "{0}은(는) 유니코드 문자와 숫자만 포함할 수 있습니다.",
override: false,
},
{
tag: "numeric",
translation: "{0}은(는) 올바른 숫자여야 합니다.",
Expand Down
30 changes: 27 additions & 3 deletions translations/ko/ko_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,13 @@ func TestTranslations(t *testing.T) {
GteFieldString string `validate:"gtefield=MaxString"`
LtFieldString string `validate:"ltfield=MaxString"`
LteFieldString string `validate:"ltefield=MaxString"`
AlphaString string `validate:"alpha"`
AlphanumString string `validate:"alphanum"`
NumericString string `validate:"numeric"`
AlphaString string `validate:"alpha"`
AlphanumString string `validate:"alphanum"`
AlphaSpaceString string `validate:"alphaspace"`
AlphaNumSpaceString string `validate:"alphanumspace"`
AlphaUnicodeString string `validate:"alphaunicode"`
AlphaNumUnicodeString string `validate:"alphanumunicode"`
NumericString string `validate:"numeric"`
NumberString string `validate:"number"`
HexadecimalString string `validate:"hexadecimal"`
HexColorString string `validate:"hexcolor"`
Expand Down Expand Up @@ -223,6 +227,10 @@ func TestTranslations(t *testing.T) {

test.AlphaString = "abc3"
test.AlphanumString = "abc3!"
test.AlphaSpaceString = "abc3"
test.AlphaNumSpaceString = "abc!"
test.AlphaUnicodeString = "abc3"
test.AlphaNumUnicodeString = "abc!"
test.NumericString = "12E.00"
test.NumberString = "12E"

Expand Down Expand Up @@ -472,6 +480,22 @@ func TestTranslations(t *testing.T) {
ns: "Test.AlphaString",
expected: "AlphaString은(는) 알파벳만 포함할 수 있습니다.",
},
{
ns: "Test.AlphaSpaceString",
expected: "AlphaSpaceString은(는) 알파벳과 공백만 포함할 수 있습니다.",
},
{
ns: "Test.AlphaNumSpaceString",
expected: "AlphaNumSpaceString은(는) 알파벳, 숫자, 공백만 포함할 수 있습니다.",
},
{
ns: "Test.AlphaUnicodeString",
expected: "AlphaUnicodeString은(는) 유니코드 문자만 포함할 수 있습니다.",
},
{
ns: "Test.AlphaNumUnicodeString",
expected: "AlphaNumUnicodeString은(는) 유니코드 문자와 숫자만 포함할 수 있습니다.",
},
{
ns: "Test.LtFieldString",
expected: "LtFieldString은(는) MaxString보다 작아야 합니다.",
Expand Down