Skip to content

Re-enable several linters #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

nodivbyzero
Copy link
Contributor

Fixes Or Enhances

This PR re-enables several previously disabled linters and resolves the following linter issues:

  • Unnecessary leading newline (whitespace)
  • Unnecessary trailing newline (whitespace)

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner April 9, 2025 20:09
@coveralls
Copy link

Coverage Status

coverage: 73.607% (-0.6%) from 74.225%
when pulling 71115f7 on nodivbyzero:enable-more-linters
into de24491 on go-playground:master.

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as running gofmt, with its default settings, doesn’t put them back/ fight against the linter. Because that’s how I and expect everyone to format the code, using gofmt/goimports with the defaults.

@nodivbyzero
Copy link
Contributor Author

Got it, totally agree.

@nodivbyzero nodivbyzero merged commit 0540a5e into go-playground:master Apr 11, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants