Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1310): fix excluded_if for pointers #1313

Conversation

ganeshdipdumbare
Copy link
Contributor

@ganeshdipdumbare ganeshdipdumbare commented Aug 27, 2024

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

- fixes go-playground#1310
- add check for pointers in case of excluded_if
@ganeshdipdumbare ganeshdipdumbare requested a review from a team as a code owner August 27, 2024 14:21
@coveralls
Copy link

Coverage Status

coverage: 74.292% (+0.001%) from 74.291%
when pulling 3746a07 on ganeshdipdumbare:fix-#1310-exclude-if-nil-ptr-issue
into a947377 on go-playground:master.

@deankarn deankarn merged commit 4a073cc into go-playground:master Sep 9, 2024
15 checks passed
renovate bot referenced this pull request in nobl9/sloctl Sep 9, 2024
….1 (#203)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/go-playground/validator/v10](https://redirect.github.com/go-playground/validator)
| `v10.22.0` -> `v10.22.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.0/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.0/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-playground/validator
(github.com/go-playground/validator/v10)</summary>

###
[`v10.22.1`](https://redirect.github.com/go-playground/validator/releases/tag/v10.22.1):
Release 10.22.1

[Compare
Source](https://redirect.github.com/go-playground/validator/compare/v10.22.0...v10.22.1)

#### What's Changed

-
fix([#&#8203;1310](https://redirect.github.com/go-playground/validator/issues/1310)):
fix excluded_if for pointers by
[@&#8203;ganeshdipdumbare](https://redirect.github.com/ganeshdipdumbare)
in
[https://github.com/go-playground/validator/pull/1313](https://redirect.github.com/go-playground/validator/pull/1313)

#### New Contributors

-
[@&#8203;ganeshdipdumbare](https://redirect.github.com/ganeshdipdumbare)
made their first contribution in
[https://github.com/go-playground/validator/pull/1313](https://redirect.github.com/go-playground/validator/pull/1313)

**Full Changelog**:
go-playground/validator@v10.22.0...v10.22.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/nobl9/sloctl).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in jippi/dottie Sep 9, 2024
…0.22.1 in go.mod (#90)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/go-playground/validator/v10](https://redirect.github.com/go-playground/validator)
| `v10.22.0` -> `v10.22.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.0/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.0/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-playground/validator
(github.com/go-playground/validator/v10)</summary>

###
[`v10.22.1`](https://redirect.github.com/go-playground/validator/releases/tag/v10.22.1):
Release 10.22.1

[Compare
Source](https://redirect.github.com/go-playground/validator/compare/v10.22.0...v10.22.1)

#### What's Changed

-
fix([#&#8203;1310](https://redirect.github.com/go-playground/validator/issues/1310)):
fix excluded_if for pointers by
[@&#8203;ganeshdipdumbare](https://redirect.github.com/ganeshdipdumbare)
in
[https://github.com/go-playground/validator/pull/1313](https://redirect.github.com/go-playground/validator/pull/1313)

#### New Contributors

-
[@&#8203;ganeshdipdumbare](https://redirect.github.com/ganeshdipdumbare)
made their first contribution in
[https://github.com/go-playground/validator/pull/1313](https://redirect.github.com/go-playground/validator/pull/1313)

**Full Changelog**:
go-playground/validator@v10.22.0...v10.22.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* */1 * * *" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/jippi/dottie).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
denyskon referenced this pull request in denyskon/postalion Sep 10, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/go-playground/validator/v10](https://redirect.github.com/go-playground/validator)
| `v10.22.0` -> `v10.22.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.0/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-playground%2fvalidator%2fv10/v10.22.0/v10.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-playground/validator
(github.com/go-playground/validator/v10)</summary>

###
[`v10.22.1`](https://redirect.github.com/go-playground/validator/releases/tag/v10.22.1):
Release 10.22.1

[Compare
Source](https://redirect.github.com/go-playground/validator/compare/v10.22.0...v10.22.1)

#### What's Changed

-
fix([#&#8203;1310](https://redirect.github.com/go-playground/validator/issues/1310)):
fix excluded_if for pointers by
[@&#8203;ganeshdipdumbare](https://redirect.github.com/ganeshdipdumbare)
in
[https://github.com/go-playground/validator/pull/1313](https://redirect.github.com/go-playground/validator/pull/1313)

#### New Contributors

-
[@&#8203;ganeshdipdumbare](https://redirect.github.com/ganeshdipdumbare)
made their first contribution in
[https://github.com/go-playground/validator/pull/1313](https://redirect.github.com/go-playground/validator/pull/1313)

**Full Changelog**:
go-playground/validator@v10.22.0...v10.22.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/denyskon/postalion).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude If doesn't work on boolean and nil parametr
3 participants