Skip to content

Conversation

@nodivbyzero
Copy link
Contributor

Fixes Or Enhances

This PR adds time.Duration translation and unit test cases.

Connected to: #1069

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner August 29, 2023 22:32
@coveralls
Copy link

Coverage Status

coverage: 73.861% (+0.02%) from 73.843% when pulling f5e6d36 on nodivbyzero:duration-translation-en-fix into 1b40ba0 on go-playground:master.

@coveralls
Copy link

Coverage Status

coverage: 75.291% (+0.01%) from 75.277%
when pulling f94273c on nodivbyzero:duration-translation-en-fix
into 002f6c6 on go-playground:master.

@nodivbyzero
Copy link
Contributor Author

@deankarn please review when you have time

@nodivbyzero nodivbyzero merged commit 7d97147 into go-playground:master Feb 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants