Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set timeout for TLS connections #18

Merged
merged 2 commits into from
Dec 18, 2022
Merged

fix: set timeout for TLS connections #18

merged 2 commits into from
Dec 18, 2022

Conversation

gurza
Copy link
Contributor

@gurza gurza commented Oct 4, 2022

Closes #17

@gurza gurza marked this pull request as draft October 5, 2022 19:54
@gurza gurza marked this pull request as ready for review December 17, 2022 08:54
@gurza
Copy link
Contributor Author

gurza commented Dec 17, 2022

@umputun please review this PR

@umputun umputun self-requested a review December 18, 2022 18:56
umputun
umputun approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, LGMT

@umputun umputun merged commit 13855b6 into go-pkgz:master Dec 18, 2022
@gurza gurza deleted the fix/tls-timeout branch December 19, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sender timeOut doesn't work for TLS connections
2 participants
@gurza @umputun