Fix styling on go files. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple of big issues. 1) Structs that were returned from public methods were not visible. 2) When a var is set in the same line as it is declared you should use type inference. not: var silly int = 42 but: var silly = 42 3) Errors should be named ErrSomethingBad, not SomethingBadError
1 similar comment
|
Nice job! Thanks! |
|
No problem.
…On Fri, Jan 19, 2018, 3:21 PM Qiang Xue ***@***.***> wrote:
Nice job! Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArbL99Yy3--Zqwa6KypCld8i0IPkx0iks5tMSOXgaJpZM4RlEfW>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of big issues.
not: var silly int = 42
but: var silly = 42