Ref in paths / responses / parameters: flatten $ref in Paths (covers skip schemas) #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 58.42% 58.76% +0.34%
==========================================
Files 25 25
Lines 1912 1928 +16
==========================================
+ Hits 1117 1133 +16
+ Misses 615 614 -1
- Partials 180 181 +1
Continue to review full report at Codecov.
|
golangcibot
reviewed
Dec 24, 2019
fredbi
force-pushed
the
fix-2113-skip-schemas
branch
2 times, most recently
from
af319ff to
35332c9
Compare
fredbi
changed the title
fredbi
force-pushed
the
fix-2113-skip-schemas
branch
from
35332c9 to
1a169ef
Compare
fredbi
force-pushed
the
fix-2113-skip-schemas
branch
from
1a169ef to
4c01586
Compare
* added some quick patches to keep things running on windows: a more elaborate approach is still needed to fully support file $ref on windows Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix-2113-skip-schemas
branch
from
4c01586 to
cf8db28
Compare
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
changed the title
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the case of $ref's under Path, with some schemas inside. Previous PR #110 did not rebase correctly non-expanded $refs when flatten skips schema expansion.
NOTE: had to add some quick patches to keep things working on windows, although we know that windows support for $ref is still patchy at the moment (see issue #97)