Skip to content

Enhancement to allow backup binlogs using a specified GTID set #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Enhancement to allow backup binlogs using a specified GTID set #1050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443c85e
Enhancement to allow syncing binlogs using a specified GTID set
Jul 7, 2025
c6092a4
Run gofumpt
Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run gofumpt
  • Loading branch information
Deepak Gupta committed Jul 8, 2025
commit c6092a4577d16e9439c1e80bbafee0d4035f3af8
1 change: 0 additions & 1 deletion replication/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ func (b *BinlogSyncer) StartSynchronousBackup(p mysql.Position, timeout time.Dur

// StartSynchronousBackupWithGTID starts the backup process using the SynchronousEventHandler in the BinlogSyncerConfig with a specified GTID set.
func (b *BinlogSyncer) StartSynchronousBackupWithGTID(gset mysql.GTIDSet, timeout time.Duration) error {

if b.cfg.SynchronousEventHandler == nil {
return errors.New("SynchronousEventHandler must be set in BinlogSyncerConfig to use StartSynchronousBackupWithGTID")
}
Expand Down
3 changes: 2 additions & 1 deletion replication/backup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ package replication
import (
"context"
"fmt"
"github.com/google/uuid"
"io"
"os"
"path"
"time"

"github.com/google/uuid"

"github.com/stretchr/testify/require"

"github.com/go-mysql-org/go-mysql/mysql"
Expand Down
Loading