Fix capture group replacement in URLFor / URLWith #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if specifying a standard capture group (as specified by http://golang.org/pkg/regexp/syntax/) in a route, the replacement in URLWith needs to include the appropriate regex, in addition to the :name sugar
|
👍 Works perfect! |
|
Awesome! Merging! |
erizocosmico
pushed a commit
that referenced
this pull request
Jun 17, 2014
Fix capture group replacement in URLFor / URLWith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using standard syntax for capture groups, the replacements are not properly made in
URLForwhen given sufficient arguments.Adjusting the regex in
URLWithto include the(?P...)syntax addresses the issue without impact to existing behavior.