-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vgo requires a "v" prefix to recognize tagged releases #35
Comments
Thanks for opening this issue. When this project first started, tags were created without the In the meantime, you could try this workaround from golang/go#23954 (comment):
Sorry for the extra hurdle. I know this is less than ideal... |
Thanks for looking into the issue! The "suggested" workaround is already present in Go 1.11's tool chain. The problem w/ the workaround is that upgrades aren't honored. e.g. For example, I originally pinned my dependency to this package to version Please reconsider. |
@ivy Please don't close issues, but leave open for discuss... maybe create labels |
@dhui You'll have to fill me in a bit, I haven't personally made the switch to vgo yet so some of this is going to need more investigation on my part. So if I understand, that workaround solves the issue of initially In either case, I'm perfectly happy to consider tagging future releases with a
@pedromorgan I closed this issue under the assumption that this is a bug the Go team should address. Vgo is still a prototype, last I checked and I don't want to change the release policy without carefully weighing the decision. I think we can both agree that this issue's worth reopening if that turns out not to be the case. Personally, I don't think that's likely though, given their discipline of never breaking backwards compatibility. 🤷♀️ |
Modules have been merged into Go 1.11 and will automatically be enabled if your project lives outside of the I believe that there are 2 ways to "support" modules:
|
@ivy Thanks for fixing and following up! v2.3.0 works well for me $ go mod why gopkg.in/mail.v2
# gopkg.in/mail.v2
<REDACTED>
github.com/go-mail/mail/v2
github.com/go-mail/mail/v2.test
$ This results in different versions of $ git grep /mail go.sum
go.sum:github.com/go-mail/mail/v2 v2.3.0 h1:wha99yf2v3cpUzD1V9ujP404Jbw2uEvs+rBJybkdYcw=
go.sum:github.com/go-mail/mail/v2 v2.3.0/go.mod h1:oE2UK8qebZAjjV1ZYUpY7FPnbi/kIU53l1dmqPRb4go=
go.sum:gopkg.in/mail.v2 v2.0.0-20180731213649-a0242b2233b4 h1:a3llQg4+Czqaf+QH4diHuHiKv4j1abMwuRXwaRNHTPU=
go.sum:gopkg.in/mail.v2 v2.0.0-20180731213649-a0242b2233b4/go.mod h1:htwXN1Qh09vZJ1NVKxQqHPBaCBbzKhp5GzuJEA4VJWw=
$ Once that import is fixed, you can probably clean up .travis.yml Also, as an FYI, I've learned that consumers can work around module version issues by using the replace directive. |
Git tags need a
v
prefix to be recognized as a Go module versionSee: golang/go#24007 (comment)
e.g. for version
2.3.0
, the git tag should bev2.3.0
The text was updated successfully, but these errors were encountered: