Skip to content

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Aug 20, 2021

No description provided.

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Your editor seems to be set to a slightly higher maximum line length than mine. Do you know what that limit is?

@pohly pohly merged commit 31ff767 into go-logr:master Aug 20, 2021
iand pushed a commit to iand/logr that referenced this pull request Sep 1, 2021
golangci-lint by default suppresses issues about invalid
comments. This let some real errors (cut-and-paste, incomplete rename)
slip through.

Fixes: go-logr#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants