Merge pull request #88 from vvakame/fix-typed-nil

handle typed nil on field
go-logr · Sep 7, 2021 · 59f2313 · 59f2313
2 parents 5e3dfaa + 014a2c3
commit 59f2313
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/funcr/funcr.go b/funcr/funcr.go
@@ -287,6 +287,9 @@ func prettyWithFlags(value interface{}, flags uint32) string {
 		buf.WriteRune('}')
 		return buf.String()
 	case reflect.Ptr, reflect.Interface:
+		if v.IsNil() {
+			return "null"
+		}
 		return pretty(v.Elem().Interface())
 	}
 	return fmt.Sprintf(`"<unhandled-%s>"`, t.Kind().String())

diff --git a/funcr/funcr_test.go b/funcr/funcr_test.go
@@ -95,6 +95,15 @@ func TestPretty(t *testing.T) {
 			{"nine", "three"},
 			{"seven", "six"},
 		},
+		struct {
+			A *int
+			B *int
+			C interface{}
+			D interface{}
+		}{
+			B: ptrint(1),
+			D: interface{}(2),
+		},
 	}
 
 	for i, tc := range cases {