Added all Microsoft LDAP OIDs #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuschma
requested changes
May 20, 2025
There was a problem hiding this comment.
Thank you for your PR and adding the missing LDAP controls! Unfortunately you want to change already existing and exported variables, which would break backwards compatibility.
May you revert the changes to the variables and descriptions to fix this? Thank you!
|
Hi @cpuschma! I have updated the code taking into account your remarks Best regards, |
cpuschma
approved these changes
May 20, 2025
|
Thank you for your PR, @p0dalirius ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request adds all OIDs used in Microsoft LDAP.
Best regards,