Skip to content

Fix project import #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2014
Merged

Fix project import #670

merged 2 commits into from
Mar 27, 2014

Conversation

@d3xter
Copy link
Contributor

@d3xter d3xter commented Mar 26, 2014

Fixed 2 small bugs within the project importer:

  1. i used the wrong separator, so there would be a "Go_Test:Go_Test.iml" outside of the project root
  2. The newly created module has to inherit the SDK from the project, otherwise the SDK-sources are not available in the module

Andreas Sinz added 2 commits March 26, 2014 21:13
Use File.separator instead of File.pathSeparator
bae73d6 
The .iml file of the project will now be located inside the project root
Inherit the project sdk into the created module
d61441d 
We need to inherit the sdk from the project,
otherwise the SDK will not be added as a dependency to the module
mtoader added a commit that referenced this pull request Mar 27, 2014
@mtoader
Merge pull request #670 from d3xter/fix_project_import
3abd875 
Fix project import
@mtoader mtoader merged commit 3abd875 into go-lang-plugin-org:master Mar 27, 2014
@d3xter d3xter deleted the fix_project_import branch March 27, 2014 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d3xter @mtoader