Fixes #639: Debugger Failure when encountering "=" prefixed output #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for empty line before substring(0, 1)
…interpreted as such. ** This is a hack **. for some unknown reason, GDB is outputting lines which are clearly stdout from the debugged program, but are not @ prefixed. This means that lines that happen to start with mi2 control characters are being passed into mi2 parsing functions that themselves do very little validation before `substring`ing everywhere.
|
@dlsniper can you check the validity of this ? I have no idea how the debugger works now. |
|
Without an actual line of output that replicates the problem I'm not sure about this either. The current parser does have its weak spots caused by gdb/mi being very inconsistent in output. I'll have a look over it more closely tomorrow. |
|
If it helps, when I get home I will post a short go program that triggers |
|
This can be merged as well as far as I can see, sorry for the long time it took me to get back on this. |
mtoader
added a commit
that referenced
this pull request
Mar 27, 2014
Fixes #639: Debugger Failure when encountering "=" prefixed output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack. for some unknown reason, GDB is outputting lines which are clearly stdout from the debugged program, but are not
@prefixed. This means that lines that happen to start with mi2 control characters are being passed into mi2 parsing functions that themselves do very little validation beforesubstringing everywhere.That being said, it works, and it should protect against a whole class of invalid parsing (as described in #639).