Skip to content

Remove the null errors from the JSON outputs #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2019
Merged

Remove the null errors from the JSON outputs #26

merged 2 commits into from
Jul 19, 2019

Conversation

campoy
Copy link
Contributor

@campoy campoy commented Jul 19, 2019

The code in the examples sets omitempty so the output will never contain "err":null.

campoy added 2 commits July 19, 2019 14:36
@campoy
Remove the null errors from the JSON outputs
8e472c2 
The code in the examples sets `omitempty` so the output will never contain `"err":null`.
@campoy
Remove remaining null error
084a291
peterbourgon
peterbourgon approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@peterbourgon peterbourgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, good catch.

@peterbourgon peterbourgon merged commit b9582ef into go-kit:source Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbourgon peterbourgon peterbourgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@campoy @peterbourgon