-
Notifications
You must be signed in to change notification settings - Fork 8
Bump Go and change CI/CD. #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go and change CI/CD. #16
Conversation
Also fix golang/go#65051 and resolve obvious linting problems.
e274ad6
to
151e3bf
Compare
@rogpeppe, @mhilton, @tasdomas, @alesstimec, I'd appreciate your reviews, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of trivial suggestions.
@rogpeppe, I think we can merge, thanks |
Hey @rogpeppe, any updates? |
1 similar comment
Hey @rogpeppe, any updates? |
Hey @rogpeppe, could you kindly review and merge this PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor suggestion, which can be done as a follow-up if desired. Sorry for the ultra-slow review!
@@ -1,4 +1,5 @@ | |||
// +build go1.8 | |||
//go:build go1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem necessary anymore.
Also fix golang/go#65051 and resolve obvious linting problems.