Skip to content

Bump Go and change CI/CD. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

andrei-polukhin
Copy link
Contributor

Also fix golang/go#65051 and resolve obvious linting problems.

Also fix golang/go#65051
and resolve obvious linting problems.
@andrei-polukhin andrei-polukhin force-pushed the bump-go-and-dependencies branch from e274ad6 to 151e3bf Compare April 10, 2024 08:02
@andrei-polukhin
Copy link
Contributor Author

andrei-polukhin commented Apr 10, 2024

@rogpeppe, @mhilton, @tasdomas, @alesstimec, I'd appreciate your reviews, thanks.

Copy link
Contributor

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of trivial suggestions.

@andrei-polukhin
Copy link
Contributor Author

@rogpeppe, I think we can merge, thanks

@andrei-polukhin
Copy link
Contributor Author

Hey @rogpeppe, any updates?

1 similar comment
@andrei-polukhin
Copy link
Contributor Author

Hey @rogpeppe, any updates?

@andrei-polukhin
Copy link
Contributor Author

Hey @rogpeppe, could you kindly review and merge this PR? Thanks.

Copy link
Contributor

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor suggestion, which can be done as a follow-up if desired. Sorry for the ultra-slow review!

@@ -1,4 +1,5 @@
// +build go1.8
//go:build go1.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem necessary anymore.

@rogpeppe rogpeppe merged commit b04b965 into go-httprequest:v1 Jan 20, 2025
@andrei-polukhin andrei-polukhin deleted the bump-go-and-dependencies branch January 21, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net/http, x/net/http2: close connections when receiving too many headers (CVE-2023-45288)
3 participants