Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for color templates #163

Closed
oriordan opened this issue Sep 29, 2016 · 1 comment
Closed

Support for color templates #163

oriordan opened this issue Sep 29, 2016 · 1 comment

Comments

@oriordan
Copy link
Contributor

Graphite had support for different color templates in graphTemplates.conf, using &template= parameter. Carbonapi currently doesn't support this (and I'm not sure it should, really), but as discussed raising a case for it.

Note that this feature was removed in latest graphite (according to the docs), and has been replaced with something completely different (http://graphite.readthedocs.io/en/latest/render_api.html#template) which might be nice to support.

@Civil Civil added this to the 1.0 milestone Apr 26, 2017
@Civil Civil closed this as completed in 21c5a3c Feb 28, 2018
@Civil
Copy link
Member

Civil commented Feb 28, 2018

Sorry that it took so long to fix.

Current master (and upcoming 0.10 release) supports that functionality. Though carbonapi can't parse graphite's graphTemplates as-is, you need to convert them from ini-style to toml (that's pretty easy though).

gunnihinn pushed a commit to bookingcom/carbonapi that referenced this issue Oct 1, 2018
It's the only remaining part of the code that uses viper. Since we're by
now not compatible with graphite-web by not having Graph templates, and
we're also not compatible with graphite-web by having this
implementation of Graph templates, let's settle on the noncompatibility
that brings us the least pain for now.

See

    go-graphite/carbonapi#163

for more.
npazosmendez pushed a commit that referenced this issue Jun 30, 2023
Use IntOrInf type for keepLastValue and interpolate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants