Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go mod and fix github.com paths and add float32 #81

Closed
wants to merge 14 commits into from

Conversation

pa-m
Copy link

@pa-m pa-m commented Feb 25, 2019

Hi,
module was unusable since github path changed but source had references to previous github url.
Best regards

@zeroviscosity
Copy link

I think this should be two PRs: one for the go mod update and a separate one for the float32 changes.

@pa-m
Copy link
Author

pa-m commented Feb 25, 2019

I think this should be two PRs: one for the go mod update and a separate one for the float32 changes.

Right, but 2nd depends from 1st

@pa-m pa-m changed the title use go mod and fix github.com paths use go mod and fix github.com paths and add float32 Feb 25, 2019
@pa-m pa-m mentioned this pull request Feb 25, 2019
@danicat
Copy link
Contributor

danicat commented Apr 2, 2019

@pa-m please target your PR to the dev branch instead of master.

@kniren
Copy link
Collaborator

kniren commented Sep 26, 2019

Already fixed in #97

@kniren kniren closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants