Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some functionality #180

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

add some functionality #180

wants to merge 62 commits into from

Conversation

mqy527
Copy link

@mqy527 mqy527 commented Mar 9, 2022

add: series rolling, series calculation with number and another series、logical operation

Copy link
Contributor

@chrmang chrmang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big PR with a lot of new functionality and breaking changes. Maybe we should open an issue to discuss your intention. Breaking changes need always some planning.

@@ -5,8 +5,8 @@ import (
"strconv"
"testing"

"github.com/go-gota/gota/dataframe"
"github.com/go-gota/gota/series"
"github.com/mqy527/gota/dataframe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope, this is a mistake - keep go-gota here.

@@ -41,7 +41,7 @@ type DataFrame struct {

// New is the generic DataFrame constructor
func New(se ...series.Series) DataFrame {
if se == nil || len(se) == 0 {
if len(se) == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants