fix(Migrator): add schema qualification to GetIndexes, RenameIndex, DropIndex#340
Merged
Merged
Conversation
…ropIndex GetIndexes, RenameIndex, and DropIndex did not use CurrentSchema to qualify index operations, causing incorrect results when tables reside in non-default schemas. This aligns them with HasIndex, HasTable, and HasColumn which already call CurrentSchema. Closes go-gorm#226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
Problem
GetIndexes, RenameIndex, and DropIndex do not use CurrentSchema to qualify index operations. This causes incorrect results when tables reside in non-default PostgreSQL schemas.
By contrast, HasIndex, HasTable, HasColumn, and HasConstraint all call CurrentSchema/CurrentTable to filter by schema.
Changes
All three follow the same pattern already used by HasIndex and other methods in this file.