Rename expr type to make it public. #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
=======================================
Coverage 79.42% 79.42%
=======================================
Files 24 24
Lines 3466 3466
=======================================
Hits 2753 2753
Misses 612 612
Partials 101 101
Continue to review full report at Codecov.
|
blefevre
pushed a commit
to blefevre/gorm
that referenced
this pull request
Feb 17, 2020
cgxxv
pushed a commit
to cgxxv/gorm
that referenced
this pull request
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several cases I've really wanted the ability to return the result of calling
QueryExprfrom a function. Theexprtype being private prevents being able to write a function that returns or accepts it. The public constructor for this type doesn't do anything besides forward the args. I'm assuming this was private in the first place to allow future refactoring, but this has been stable for some time. This would be a significant usability improvement.