Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncapitalize error strings #2533

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Uncapitalize error strings #2533

merged 1 commit into from
Sep 12, 2019

Conversation

zaneli
Copy link
Member

@zaneli zaneli commented Jul 1, 2019

Make sure these boxes checked before submitting your pull request.

  • Do only one thing
  • No API-breaking changes
  • New code/logic commented & tested

For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.

What did this pull request do?

Error strings should not be capitalized, so fixed it.
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

@codecov-io
Copy link

Codecov Report

Merging #2533 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2533   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files          24       24           
  Lines        3466     3466           
=======================================
  Hits         2753     2753           
  Misses        612      612           
  Partials      101      101
Impacted Files Coverage Δ
callback_delete.go 94.59% <100%> (ø) ⬆️
callback_update.go 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836fb2c...37ca299. Read the comment docs.

@jinzhu jinzhu merged commit 13f19a5 into go-gorm:master Sep 12, 2019
@zaneli zaneli deleted the fix-error-message branch September 12, 2019 14:29
blefevre pushed a commit to blefevre/gorm that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants