Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort column names before generating SQL in DB.UpdateColumns #1734

Merged
merged 2 commits into from
Feb 10, 2018

Conversation

smithjessk
Copy link
Contributor

@smithjessk smithjessk commented Jan 22, 2018

Make sure these boxes checked before submitting your pull request.

  • Do only one thing
  • No API-breaking changes
  • New code/logic commented & tested
  • Write good commit message, try to squash your commits into a single one
  • Run ./build.sh in gh-pages branch for document changes (I couldn't get gitbook to install the plugins necessary. I will try again tomorrow)

For significant changes like big bug fixes, new features, please open an issue to make a agreement on an implementation design/plan first before starting it.

Thank you.

What did this pull request do?

Addresses #1700.

I tested it by looking at the SQL field of the scope in DB.UpdateColumns. Across multiple runs, the generated SQL did not change.

@smithjessk
Copy link
Contributor Author

build.sh failed because I didn't have gitbook's plugins. The error message implied that, to get the plugins, I should run gitbook install from the current directory. However, this doesn't fix the problem; gitbook install must be run from documents/. Maybe we should put this either in the gh-pages README or in the PR instructions? I'd be happy to do so, and would put it in a new PR that I would tag here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants