Do not ignore order on distinct query #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iahmedov
pushed a commit
to housinganywhere/gorm
that referenced
this pull request
Sep 3, 2018
blefevre
pushed a commit
to blefevre/gorm
that referenced
this pull request
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes checked before submitting your pull request.
./build.shingh-pagesbranch for document changesFor significant changes like big bug fixes, new features, please open an issue to make a agreement on an implementation design/plan first before starting it.
Thank you.
What did this pull request do?
I am trying to run query like this:
DB.Model(&Entry{}).Select("DISTINCT date_part('year', created_at) as year").Order("year desc")And the years are not ordered. I am not sure what the reasoning behind ignoring order on distinct was, but I need the years ordered.