Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update default version #9916

Merged
merged 5 commits into from
Jan 25, 2020
Merged

chore: update default version #9916

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4757a48
chore: update default version
sapk Jan 21, 2020
7849794
Merge branch 'master' into updt-version
sapk Jan 21, 2020
048fd54
use develop
sapk Jan 21, 2020
6ac6097
Update main.go
sapk Jan 25, 2020
376c0e4
Merge branch 'master' into updt-version
sapk Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (

var (
// Version holds the current Gitea version
Version = "1.9.0-dev"
Version = "1.12.0-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if we have this set to 0.0.0-dev, as we have our makefile override this, and then we could also distinguish better when the binary is built via go build without version info passedin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-dev is already specific to direct build ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe have it blank like the below variables?

sapk marked this conversation as resolved.
Show resolved Hide resolved
// Tags holds the build tags used
Tags = ""
// MakeVersion holds the current Make version if built with make
Expand Down