Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dump non-exist log directory #9818

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix dump non-exist log directory #9818

merged 1 commit into from
Jan 17, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 17, 2020

Fix #9745

@lunny lunny added this to the 1.12.0 milestone Jan 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2020
@techknowlogick techknowlogick merged commit 9f40bb0 into go-gitea:master Jan 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #9818 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9818      +/-   ##
==========================================
+ Coverage   42.22%   42.22%   +<.01%     
==========================================
  Files         603      603              
  Lines       78879    78880       +1     
==========================================
+ Hits        33306    33308       +2     
  Misses      41491    41491              
+ Partials     4082     4081       -1
Impacted Files Coverage Δ
cmd/dump.go 0% <0%> (ø) ⬆️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
models/repo.go 46.86% <0%> (+0.12%) ⬆️
services/pull/patch.go 64.77% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2916d...b6378e7. Read the comment docs.

@techknowlogick
Copy link
Member

@lunny please backport :)

@lunny lunny deleted the lunny/fix_dump branch January 17, 2020 03:14
lunny added a commit to lunny/gitea that referenced this pull request Jan 17, 2020
@lunny
fix dump non-exist log directory (go-gitea#9818)
a3d59ce
lunny added a commit to lunny/gitea that referenced this pull request Jan 17, 2020
@lunny
fix dump non-exist log directory (go-gitea#9818)
51ec7fc
This was referenced Jan 17, 2020
Merged
Merged
lunny added a commit that referenced this pull request Jan 17, 2020
@lunny
fix dump non-exist log directory (#9818) (#9819)
f766719
sapk pushed a commit that referenced this pull request Jan 17, 2020
@lunny @lafriks @sapk
fix dump non-exist log directory (#9818) (#9820)
9809fe2 
Co-authored-by: Lauris BH <lauris@nix.lv>
@6543
Copy link
Member

6543 commented Jan 17, 2020

Need backport done lable

@sapk sapk added the backport/done All backports for this PR have been created label Jan 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

gitea dump fails if log directory is not present, even if file logging is disabled
6 participants
@lunny @codecov-io @techknowlogick @6543 @sapk @GiteaBot