Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: fix XSS attack on alert #973

Merged
merged 1 commit into from
Feb 19, 2017
Merged

Security: fix XSS attack on alert #973

merged 1 commit into from
Feb 19, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 18, 2017

No description provided.

@lunny lunny added backport/v1.0 topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! labels Feb 18, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 18, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 19, 2017
@tboerger
Copy link
Member

Safe suggests that it prevents XSS attack vectors... But LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2017
@lunny lunny merged commit b8f70a2 into go-gitea:master Feb 19, 2017
@lunny lunny deleted the lunny/fix_xss_alert branch February 19, 2017 11:18
@lunny lunny added the backport/done All backports for this PR have been created label Feb 19, 2017
@appleboy appleboy mentioned this pull request Feb 19, 2017
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @appleboy @tboerger @unknwon