Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for repo watching #963

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Unit tests for repo watching #963

merged 1 commit into from
Feb 17, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Feb 16, 2017 •
edited
Loading

Move the watching-related functionality of models/repo.go to models/repo_watch.go, and add unit tests for models/repo_watch.go.

@lunny
Copy link
Member

lunny commented Feb 17, 2017

build failed.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 17, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2017
@lunny
Copy link
Member

lunny commented Feb 17, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2017
@lunny lunny merged commit be48b32 into go-gitea:master Feb 17, 2017
@ethantkoenig ethantkoenig deleted the test/repo_watch branch February 18, 2017 16:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @lunny @appleboy @tboerger @andreynering