Skip to content

Conversation

@jolheiser
Copy link
Member

Resolves #9433

Also updated to show it returns a 201 rather than a 200

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #9434 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9434      +/-   ##
=========================================
+ Coverage   41.48%   41.5%   +0.01%     
=========================================
  Files         570     570              
  Lines       74324   74324              
=========================================
+ Hits        30834   30846      +12     
+ Misses      39652   39638      -14     
- Partials     3838    3840       +2
Impacted Files Coverage Δ
routers/api/v1/repo/status.go 44.53% <100%> (ø) ⬆️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
models/repo_list.go 73.14% <0%> (-0.93%) ⬇️
models/gpg_key.go 55.59% <0%> (+0.55%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️
services/pull/check.go 53.52% <0%> (+4.92%) ⬆️
modules/indexer/code/indexer.go 55.26% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57f763...fb5eac1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2019
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old code :) from 1.3.0 -> now

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2019
@6543
Copy link
Member

6543 commented Dec 19, 2019

@techknowlogick should we backport to 1.10.2 ?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2019
@zeripath zeripath merged commit f5a25d5 into go-gitea:master Dec 19, 2019
@jolheiser jolheiser deleted the create_status branch December 19, 2019 21:47
jolheiser added a commit to jolheiser/gitea that referenced this pull request Dec 19, 2019
Signed-off-by: jolheiser <john.olheiser@gmail.com>
sapk pushed a commit that referenced this pull request Dec 19, 2019
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@sapk sapk added the backport/done All backports for this PR have been created label Dec 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Swagger: repoCreateStatus returns Status instead of an Array<Status>

7 participants