Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gogits/git-module dependency with go-gitea/git #94

Merged
merged 2 commits into from
Nov 6, 2016
Merged

Replace gogits/git-module dependency with go-gitea/git #94

merged 2 commits into from
Nov 6, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 6, 2016

Fixes #92

tboerger
tboerger suggested changes Nov 6, 2016
View reviewed changes
cmd/serve.go
@@ -14,7 +14,7 @@ import (
"time"

"github.com/Unknwon/com"
git "github.com/gogits/git-module"
git "github.com/go-gitea/git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this git alias everywhere, not needed anymore.

@codecov-io
Copy link

codecov-io commented Nov 6, 2016 •
edited
Loading

Current coverage is 2.24% (diff: 100%)

Merging #94 into master will not change coverage

@@            master       #94   diff @@
========================================
  Files           32        32          
  Lines         7521      7521          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           169       169          
  Misses        7335      7335          
  Partials        17        17

Powered by Codecov. Last update 55a4d46...58ff8ea

@strk
Copy link
Member Author

strk commented Nov 6, 2016

On Sun, Nov 06, 2016 at 02:35:40AM -0800, Thomas Boerger wrote:

Please drop this git alias everywhere, not needed anymore.

Done.

@xinity xinity added the type/enhancement An improvement of existing functionality label Nov 6, 2016
@xinity xinity added this to the 1.0.0 milestone Nov 6, 2016
@andreynering
Copy link
Contributor

LGTM

1 similar comment
@lunny
Copy link
Member

lunny commented Nov 6, 2016

LGTM

@andreynering andreynering merged commit 6e4252d into go-gitea:master Nov 6, 2016
@strk strk deleted the git-dep branch November 6, 2016 13:27
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@HoffmannP HoffmannP mentioned this pull request Nov 23, 2018
Closed
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@mrexodia @lafriks
Introduce Blob.DataAsyc (go-gitea#94)
193e22e 
Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger requested changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Replace gogits git-module dependency
6 participants
@strk @codecov-io @andreynering @lunny @tboerger @xinity