Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful: Xorm, RepoIndexer, Cron and Others #9282

Merged
merged 41 commits into from
Dec 15, 2019
Merged

Graceful: Xorm, RepoIndexer, Cron and Others #9282

merged 41 commits into from
Dec 15, 2019

Commits on Dec 9, 2019

  1. Graceful: use GetManager instead of global

    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    5b3fa6d View commit details
    Browse the repository at this point in the history

  2. Graceful: Make repo indexer shutdown gracefully

    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    00ddf85 View commit details
    Browse the repository at this point in the history

  3. Graceful: Make the cron tasks graceful

    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    b2dea35 View commit details
    Browse the repository at this point in the history

  4. Graceful: Make TestPullRequests shutdownable 

    services/pull/check.go:TestPullRequests run runs within the shutdown
context and will respond the manager requesting it be shutdown.

In future this should probably become a persitable queue with pooled
workers but that restructure can wait.
    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    c0ea8ef View commit details
    Browse the repository at this point in the history

  5. Graceful: AddTestPullRequest run in graceful ctx

    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    7beda2d View commit details
    Browse the repository at this point in the history

  6. Graceful: SetDefaultContext for Xorm to be HammerContext

    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    db022dd View commit details
    Browse the repository at this point in the history

  7. Avoid starting graceful for migrate commands and checkout

    @zeripath
    zeripath committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    1aafb56 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Merge branch 'master' into graceful-more-things-graceful

    @zeripath
    zeripath committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    eae3144 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Graceful: DeliverHooks now can be shutdown

    @zeripath
    zeripath committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    7589a49 View commit details
    Browse the repository at this point in the history

  2. Graceful: SyncMirrors shutdown 

    Termination of syncs should take place with closure at hammer time in xorm and git
    @zeripath
    zeripath committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    89154f5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into graceful-more-things-graceful

    @zeripath
    zeripath authored Dec 11, 2019
    Configuration menu
    Copy the full SHA
    9b5d465 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Remove unnecessary ctx check

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    d7d6c86 View commit details
    Browse the repository at this point in the history

  2. Fix hammer syncing

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    1a79b2f View commit details
    Browse the repository at this point in the history

  3. rename manager.run to manager.start

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    7ce742c View commit details
    Browse the repository at this point in the history

  4. adjust ctx.Done check

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    fa751ea View commit details
    Browse the repository at this point in the history

  5. Prevent deadlock in mirror.Update on shutdown

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    19f2ca7 View commit details
    Browse the repository at this point in the history

  6. Lint doesn't permit passing in ctx nil

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    ef9db2d View commit details
    Browse the repository at this point in the history

  7. Add FIXME note to indexer/code/bleve.go

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    90bde75 View commit details
    Browse the repository at this point in the history

  8. Say CheckRepoStats: Aborting due to Shutdown instead

    @zeripath
    zeripath committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    13a808d View commit details
    Browse the repository at this point in the history

  9. Update modules/sync/unique_queue.go

    @zeripath
    zeripath authored Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f1c85e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Merge branch 'graceful-more-things-graceful' of github.com:zeripath/g… 

    …itea into graceful-more-things-graceful
    @zeripath
    zeripath committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    aa2dabd View commit details
    Browse the repository at this point in the history

  2. Make channels at start up rather than delayed

    @zeripath
    zeripath committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    d55db9e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into graceful-more-things-graceful

    @zeripath
    zeripath authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    398ab3b View commit details
    Browse the repository at this point in the history

  4. Make repo indexer shutdown safely

    @zeripath
    zeripath committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    c93f1a7 View commit details
    Browse the repository at this point in the history

  5. Update manager.go 

    Remove unnecessary locking
    @zeripath
    zeripath authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    4411cae View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Merge branch 'master' into graceful-more-things-graceful

    @zeripath
    zeripath authored Dec 14, 2019
    Configuration menu
    Copy the full SHA
    5c2b081 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into graceful-more-things-graceful

    @lunny
    lunny authored Dec 14, 2019
    Configuration menu
    Copy the full SHA
    9faf8da View commit details
    Browse the repository at this point in the history

  3. oops

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    cb2ac9b View commit details
    Browse the repository at this point in the history

  4. Better error reporting

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    607f2c2 View commit details
    Browse the repository at this point in the history

  5. fixup

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    a4a722f View commit details
    Browse the repository at this point in the history

  6. Push TestPullRequests to the UniqueQueue and make UniqueQueue closable

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    a9269a5 View commit details
    Browse the repository at this point in the history

  7. Ensure webhook queue is also closed to prevent blockage on add here

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    3b97005 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary channel check

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    c227a34 View commit details
    Browse the repository at this point in the history

  9. Double check that we are not trying to add id to the table again

    @zeripath
    zeripath committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    0e38ea8 View commit details
    Browse the repository at this point in the history

  10. Sort results of getunindexrepos by descending id

    @zeripath
    zeripath authored Dec 14, 2019
    Configuration menu
    Copy the full SHA
    244b54a View commit details
    Browse the repository at this point in the history

  11. Ensure repos only added once to queue

    @zeripath
    zeripath authored Dec 14, 2019
    Configuration menu
    Copy the full SHA
    2098dd2 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into graceful-more-things-graceful

    @zeripath
    zeripath authored Dec 14, 2019
    Configuration menu
    Copy the full SHA
    1374ad2 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2019

  1. D'oh

    @zeripath
    zeripath authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    d42cf0d View commit details
    Browse the repository at this point in the history

  2. Skip duplicate exist check in addfunc 

    As per @guillep2k. We check if the id is in the pool under the write lock, there's no need to pre check under the read lock
    @zeripath
    zeripath authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    be4388c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into graceful-more-things-graceful

    @lunny
    lunny authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    3e79dae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into graceful-more-things-graceful

    @zeripath
    zeripath authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    caeecd2 View commit details
    Browse the repository at this point in the history