Small optimization for getTeamIDs #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
appleboy
approved these changes
Feb 13, 2017
|
LGTM |
tboerger
added
the
lgtm/need 1
ethantkoenig
suggested changes
Feb 14, 2017
models/org.go
Outdated
| @@ -563,18 +563,22 @@ func (org *User) getUserTeams(e Engine, userID int64, cols ...string) ([]*Team, | |||
| Find(&teams) | |||
| } | |||
|
|
|||
| func (org *User) getOrgTeamIDs(e Engine, userID int64) ([]int64, error) { | |||
There was a problem hiding this comment.
Should this be getUserTeamIDs (to match GetUserTeamIDs)?
models/org.go
Outdated
| Join("INNER", "team_user", "`team_user`.team_id = team.id"). | ||
| Join("INNER", "user", "`user`.id=team_user.uid"). | ||
| And("`team_user`.uid = ?", userID). | ||
| Asc("`user`.name"). |
There was a problem hiding this comment.
Why is this ORDER BY necessary? We are only looking for one user (i.e. the user with ID userID)
Plus, if we get rid of the ORDER BY, we won't need to join with the user table 😄
ethantkoenig
approved these changes
Feb 14, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest XORM has supported only Find IDs. So let's use the new method.