Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: install on build #874

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Makefile: install on build #874

merged 1 commit into from
Feb 9, 2017

Conversation

andreynering
Copy link
Contributor

Makefile: install on build

This install Go packages on building for caching and faster builds

@andreynering
Makefile: install on build
a6b68d9 
This install Go package on building for caching and faster builds
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 9, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 9, 2017
@lunny
Copy link
Member

lunny commented Feb 9, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2017
@appleboy
Copy link
Member

appleboy commented Feb 9, 2017

LGTM Good catch.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2017
@lunny lunny merged commit e4031b8 into go-gitea:master Feb 9, 2017
@andreynering andreynering deleted the makefile-install-on-build branch February 9, 2017 09:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andreynering @lunny @appleboy @tboerger