Skip to content

Enabling and disabling the commit button to prevent empty commits (web editor) #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Enabling and disabling the commit button to prevent empty commits (web editor) #8590

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddd657d
Enabling and disabling the commit button to prevent empty commits
lukbukkit Oct 20, 2019
1b990c3
The button won't get enabled if you change the commit message
lukbukkit Oct 20, 2019
e1a8d2f
Fixes a spelling mistake for 'silent'
lukbukkit Oct 22, 2019
5e36032
Merge branch 'master' into edit-no-changes
zeripath Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion public/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,7 +1572,27 @@ function initEditor() {
});
}).trigger('keyup');

$('#commit-button').click(function (event) {
// Using events from https://github.com/codedance/jquery.AreYouSure#advanced-usage
// to enable or disable the commit button
const $commitButton = $('#commit-button');
const $editForm = $('.ui.edit.form');
const dirtyFileClass = 'dirty-file';

// Disabling the button at the start
$commitButton.prop('disabled', true);

// Registering a custom listener for the file path and the file content
$editForm.areYouSure({
silent: true,
dirtyClass: dirtyFileClass,
fieldSelector: ':input:not(.commit-form-wrapper :input)',
change: function () {
const dirty = $(this).hasClass(dirtyFileClass);
$commitButton.prop('disabled', !dirty);
}
});

$commitButton.click(function (event) {
// A modal which asks if an empty file should be committed
if ($editArea.val().length === 0) {
$('#edit-empty-content-modal').modal({
Expand Down