Skip to content

Fix version-validation for GO 1.13 (go-macaron/cors) #8389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2019
Merged

Fix version-validation for GO 1.13 (go-macaron/cors) #8389

merged 3 commits into from
Oct 6, 2019

Conversation

@6543
Copy link
Member

@6543 6543 commented Oct 6, 2019

@6543 6543 mentioned this pull request Oct 6, 2019
Closed
@6543 6543 force-pushed the fix-go-dependency_macaron-cors branch from 7e30999 to d18ba45 Compare October 6, 2019 03:17
@techknowlogick techknowlogick added this to the 1.9.4 milestone Oct 6, 2019
@techknowlogick
Copy link
Member

techknowlogick commented Oct 6, 2019

Note for maintainers reviewing: This has been solved for gitea 1.10, however as we changed the upstream dependency we couldn't backport. This will allow 1.9.4 to be built with golang 1.13

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2019
@techknowlogick
Copy link
Member

techknowlogick commented Oct 6, 2019

@6543 please update vendor/modules.txt as well

@6543 6543 changed the title fix version-validation (because of 1.12 -> 1.13 switch) WIP: fix version-validation (because of 1.12 -> 1.13 switch) Oct 6, 2019
@techknowlogick
Copy link
Member

techknowlogick commented Oct 6, 2019

nvm. I was looking at an old CI build

@6543 6543 changed the title WIP: fix version-validation (because of 1.12 -> 1.13 switch) fix version-validation (because of 1.12 -> 1.13 switch) Oct 6, 2019
@6543
Copy link
Member Author

6543 commented Oct 6, 2019

build was succesfull!!
just runn the rest of the CI ...

@6543 6543 mentioned this pull request Oct 6, 2019
Closed
@6543
Copy link
Member Author

6543 commented Oct 6, 2019

@techknowlogick works 🗡️

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2019
@6543
Copy link
Member Author

6543 commented Oct 6, 2019

CI done

@techknowlogick techknowlogick merged commit b6fba5b into go-gitea:release/v1.9 Oct 6, 2019
@6543 6543 deleted the fix-go-dependency_macaron-cors branch October 6, 2019 04:11
@6543
Copy link
Member Author

6543 commented Oct 6, 2019

now we can build 1.9.x with new fixes ...

@6543 6543 changed the title fix version-validation (because of 1.12 -> 1.13 switch) Fix version-validation for GO 1.13 (go-macaron/cors) Oct 8, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.9.4

Development

Successfully merging this pull request may close these issues.

4 participants

@6543 @techknowlogick @guillep2k @GiteaBot