Add checkbox to search for all the branches by commit message #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
suggested changes
Feb 4, 2017
options/locale/locale_en-US.ini
Outdated
| @@ -513,6 +513,7 @@ editor.upload_files_to_dir = Upload files to '%s' | |||
|
|
|||
| commits.commits = Commits | |||
| commits.search = Search commits | |||
| commits.searchAll = All | |||
There was a problem hiding this comment.
Use snake_case:
searchAll -> search_all
| func (c *Commit) SearchCommits(keyword string) (*list.List, error) { | ||
| return c.repo.searchCommits(c.ID, keyword) | ||
| func (c *Commit) SearchCommits(keyword string, all bool) (*list.List, error) { | ||
| return c.repo.searchCommits(c.ID, keyword, all) |
There was a problem hiding this comment.
You should not change this package directly in the vendor folder.
You should send PR to https://github.com/go-gitea/git first, and after aproved use govendor to update the changes here.
templates/repo/commits_table.tmpl
Outdated
| @@ -6,6 +6,7 @@ | |||
| <div class="ui tiny search input"> | |||
| <input name="q" placeholder="{{.i18n.Tr "repo.commits.search"}}" value="{{.Keyword}}" autofocus> | |||
| </div> | |||
| <input type="checkbox" name="all" id="all" value="true" {{.All}}><label for="all">{{.i18n.Tr "repo.commits.searchAll"}}</label> | |||
There was a problem hiding this comment.
Here, too:
searchAll -> search_all
andreynering
added
the
type/feature
and updating the vendor directory
|
Hope, I've done it correctly, I've never used go before :) |
tboerger
added
the
lgtm/need 2
appleboy
approved these changes
Feb 5, 2017
|
LGTM |
tboerger
added
lgtm/need 1
|
@andreynering please confirm. |
andreynering
approved these changes
Feb 5, 2017
|
@andreynering then change this to v1.1 or wait to v1.2? |
|
@lunny I think this change is simple enough and can be merged now. |
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to search for all the commits containing the entered text in their commit message, not only in the current branch