Redirects for renamed repos #807
Conversation
lunny
added
the
type/feature
|
But if A -> B, but C -> A, then A will never be visit? |
tboerger
added
the
lgtm/need 2
|
@lunny Good point, there are a lot of bugs with reusing previously-used repo names. I'll work on finding a solution. |
ethantkoenig
force-pushed
the
redirect
branch
2 times, most recently
from
0dc913c
to
493093b
Compare
|
@lunny I've added changes so that whenever a repo is created or renamed, any redirects from the new name are deleted. I believe this should fix the problem. |
models/repo_redirect.go
Outdated
| func NewRepoRedirect(ownerID, repoID int64, oldRepoName, newRepoName string) error { | ||
| oldRepoName = strings.ToLower(oldRepoName) | ||
| newRepoName = strings.ToLower(newRepoName) | ||
| if err := deleteRepoRedirect(x, ownerID, newRepoName); err != nil { |
There was a problem hiding this comment.
I would like you use a database transaction to do that.
ethantkoenig
force-pushed
the
redirect
branch
2 times, most recently
from
8239949
to
55b8a83
Compare
| @@ -14,7 +14,7 @@ | |||
| {{.CsrfTokenHtml}} | |||
| <input type="hidden" name="action" value="update"> | |||
| <div class="required field {{if .Err_RepoName}}error{{end}}"> | |||
| <label for="repo_name">{{.i18n.Tr "repo.repo_name"}}<span class="text red hide" id="repo-name-change-prompt"> {{.i18n.Tr "repo.settings.change_reponame_prompt"}}</span></label> | |||
| <label for="repo_name">{{.i18n.Tr "repo.repo_name"}}</label> | |||
There was a problem hiding this comment.
The prompt warns that "This change will affect how links relate to the repository". Once we have redirects, what the prompt says will no longer be true.
|
Otherwise LGTM |
tboerger
added
lgtm/need 1
|
If I remember correcly, the way github does it is to redirect for X period of time, during that time no new repo can be created with that name. Sounds good? |
|
@bkcsoft Github lets you create a new repo with the old name immediately; I just checked. Perhaps it used to be as you described, but not anymore? I also don't know about whether Github redirects expire. I haven't found any sources that explicitly say one way or another, and I can't easily test for myself 😄 |
|
conflicted |
ethantkoenig
force-pushed
the
redirect
branch
from
1f2a748
to
1d63de7
Compare
|
LGTM |
tboerger
added
lgtm/done
|
resolved #806 |
Adds a new table (
repo_redirect) to track what previous names should be redirected to.